bitflicker64 commented on code in PR #523:
URL: https://github.com/apache/hugegraph-doc/pull/523#discussion_r4301465856


##########
content/en/docs/config/config-backend-hstore.md:
##########
@@ -246,3 +246,22 @@ curl http://localhost:8080/metrics/backend
 The `nodes` value in the response is the count of active stores PD returns. A 
`nodes` value of `0` means the
 Server reached PD but PD has no store in state `Up`, which usually means the 
Store nodes have not registered
 yet, or registered as `Pending` because they are not in PD's 
`pd.initial-store-list`.
+
+### 9 Legacy GraphID upgrade preflight
+
+HugeGraph-Store provides legacy GraphID upgrade preflight checks during 
bootstrap and upgrade processes.
+Released 1.7.0 and earlier Store builds do not contain this preflight guard.
+Use a Store build supporting this capability before relying on the refusal 
behavior below.
+
+These Store builds check existing graph-data column families before allocating 
a missing graph ID, first opening a cold
+partition DB during metadata bootstrap, starting its Raft state machine, or 
activating a staged snapshot. Before pruning, the first cold DB open checks
+all retained valid versions. Reserved `FFFE` legacy rows cause refusal.
+An incomplete selected DB version without `CURRENT` is also rejected when it 
would hide retained valid versions. This concerns affected old write paths;
+it does not mean that every 1.7 database needs migration, and the persisted ID 
format is unchanged.
+
+On refusal, preserve the original data DB versions, metadata, WAL and 
incoming/staged snapshots. Investigate the affected write and upgrade history 
before

Review Comment:
   Minor: once #3330 lands, this section should say what a refusal does to the 
Store as a whole. At d9ff79f a cold-open refusal is not partition-scoped: 
`PartitionManager.loadPartitions` reaches the validator through `wrapper.scan` 
-> `getSession` -> `createGraphDB` with no catch, and 
`HgStoreEngine.stateChanged` only catches `InvalidShardException`, so 
`restoreLocalPartitionEngine` never runs. The Store keeps heartbeating and 
stays `Up` in PD, which the `nodes` check in section 8 reads as healthy.
   
   This is a code question already open on #3330 (per-partition skip or 
explicit exit), so it is not a defect in this page yet. When #3330 settles it, 
please add the observable result in both pages (here and CN line 222): scope, 
Store state in PD, and the log line to look for.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to