bitflicker64 commented on code in PR #523: URL: https://github.com/apache/hugegraph-doc/pull/523#discussion_r4257616971
########## content/en/docs/config/config-backend-hstore.md: ########## @@ -246,3 +246,25 @@ curl http://localhost:8080/metrics/backend The `nodes` value in the response is the count of active stores PD returns. A `nodes` value of `0` means the Server reached PD but PD has no store in state `Up`, which usually means the Store nodes have not registered yet, or registered as `Pending` because they are not in PD's `pd.initial-store-list`. + +### 9 Legacy GraphID upgrade preflight + +The following checks apply only to Store builds containing the implementation proposed in +[Apache HugeGraph #3330](https://github.com/apache/hugegraph/pull/3330). +This change is not yet merged into Apache HugeGraph or included in an Apache release. Earlier 1.8 builds do not guarantee this guard; verify that your Review Comment: Minor: "Earlier 1.8 builds do not guarantee this guard" is weaker than the code and leaves out the release people actually run (same wording on line 215 of the Chinese page: "更早的 1.8 构建不保证具备该保护"). Evidence: `git grep -c "checkLegacyGraphIdData\|resolveExistingDBPath" origin/master -- hugegraph-store` on apache/hugegraph master (0b7c0de3e) returns nothing, and the 1.7.0 tag has neither method. 1.7.0 is also where the sentinel comes from (`GraphIdManager.maxGraphID = 65535 - 1`, which is `0xFFFE`). So the check is absent from 1.7.0 and from every master build so far, not merely unguaranteed, and a 1.7.0 operator reading "earlier 1.8 builds" is not told that their Store never refuses. Requested change: state it as a fact in both pages, for example "No Apache release, including 1.7.0, and no `master` build before #3330 contains this check". This sentence and "not yet merged" also need an update in the same change that merges #3330, so please note that on the code PR. ########## content/en/docs/config/config-backend-hstore.md: ########## @@ -246,3 +246,25 @@ curl http://localhost:8080/metrics/backend The `nodes` value in the response is the count of active stores PD returns. A `nodes` value of `0` means the Server reached PD but PD has no store in state `Up`, which usually means the Store nodes have not registered yet, or registered as `Pending` because they are not in PD's `pd.initial-store-list`. + +### 9 Legacy GraphID upgrade preflight + +The following checks apply only to Store builds containing the implementation proposed in +[Apache HugeGraph #3330](https://github.com/apache/hugegraph/pull/3330). +This change is not yet merged into Apache HugeGraph or included in an Apache release. Earlier 1.8 builds do not guarantee this guard; verify that your +build contains the fix before relying on the refusal behavior below. + +These Store builds check existing graph-data column families before allocating a missing graph ID, first opening a cold +partition DB during metadata bootstrap, starting its Raft state machine, or activating a staged snapshot. Before pruning, the first cold DB open checks +all retained valid versions. Reserved `FFFE` legacy rows cause refusal. +An incomplete selected DB version without `CURRENT` is also rejected when it would hide retained valid versions. This concerns affected old write paths; +it does not mean that every 1.7 database needs migration, and the persisted ID format is unchanged. + +On refusal, preserve the original data DB versions, metadata, WAL and incoming/staged snapshots. Investigate the affected write and upgrade history before +resuming writes or replay. Do not delete graph-to-ID mappings or assign all reserved-prefix rows to one graph: different graphs may share that prefix. +Store/Raft location metadata may already have been updated before the check, so the entire bootstrap is not read-only. The check performs no automatic +migration or ownership repair; a complete 1.7 upgrade and recovery still require deployment-specific validation. + +See the +[guide for the proposed revision](https://github.com/hugegraph/hugegraph/blob/27731930ce4573481ac2f01092a288b0db239b53/docs/store-graphid-upgrade.md) Review Comment: Minor: this guide link (and the one on line 226 of `content/cn/docs/config/config-backend-hstore.md`) points at the `hugegraph/hugegraph` fork, while the sentence above it cites Apache HugeGraph #3330 as the source. Evidence: 27731930 is the current head of apache/hugegraph#3330, and the same file resolves in the Apache repository: `gh api -X GET "repos/apache/hugegraph/contents/docs/store-graphid-upgrade.md?ref=27731930ce4573481ac2f01092a288b0db239b53"` returns `https://github.com/apache/hugegraph/blob/27731930ce4573481ac2f01092a288b0db239b53/docs/store-graphid-upgrade.md`. A page on hugegraph.apache.org then sends readers to a non-Apache organisation for the upgrade guidance, and the two references in one section name two different repositories for one change. Requested change: use the apache/hugegraph URL for the pinned revision in both pages, and switch it to the `master` path once #3330 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
