imbajin commented on code in PR #517: URL: https://github.com/apache/hugegraph-doc/pull/517#discussion_r4256295709
########## content/en/docs/quickstart/hugegraph/hugegraph-hstore.md: ########## @@ -291,7 +292,7 @@ The script accepts four flags: | Flag | Values | Default | Description | |------|--------|---------|-------------| | `-d` | `true`, `false` | `true` | Daemon mode. See below. | -| `-g` | `ZGC`, `zgc` | not set | Garbage collector. Omit the flag for G1, which is the default. Any value other than `ZGC` or `zgc` aborts the start, including `g1`, even though the script's own usage line suggests it. | +| `-g` | `g1`, `G1`, `zgc`, `ZGC` | not set | Unset preserves caller/JVM GC; supplied values select G1 or ZGC (Java 17+). | Review Comment: Fixed in the current published head. The EN/ZH Store and PD pages now distinguish current master from the 1.7.0 package: explicit `zgc`/`ZGC` only on 1.7.0, with `-g g1`/`-g G1` rejected; each 1.7.0 launcher declares Java 11 while the current master launcher requires Java 17. The Store's 5s connection/30s total jemalloc budget is scoped to repaired master builds, and the 1.7.0 helper's absence of those deadlines is stated. The unchanged release archive example uses a separate bounded curl download. I read the PD/Store startup scripts and Store helper directly from the existing verified official 1.7.0 archive; their bytes match the official tag. Repository link checks, the strict Hugo build, bilingual rendered-page readbacks and an independent review passed. This is source/documentation verification; no launcher or JDK compatibility runtime test is claimed. Organization and ASF expose the same reviewed documentation source. ########## content/en/docs/quickstart/hugegraph/hugegraph-server.md: ########## @@ -123,6 +123,48 @@ The standalone `docker-compose.yml` example uses `hugegraph/hugegraph:1.7.0`; it See [docker/README.md](https://github.com/apache/hugegraph/blob/master/docker/README.md) for the full setup guide. +#### Server service identity with PD + +For a PD-backed Server, the Helm chart exposes `server.serviceId` and `server.graphSpace`. +Both default to `DEFAULT`, which preserves the existing `server.service_id` and `server.graphspace` +values in `conf/rest-server.properties`. A non-default chart value injects `HG_SERVER_SERVICE_ID` +or `HG_SERVER_GRAPHSPACE` into the Server container. Use a Helm chart and Server image from the same +version, both including the service identity support in [Server PR #3322](https://github.com/apache/hugegraph/pull/3322). +Copying these values into an older chart or image does not add that support; do not use this example +with 1.7.0 or any chart/image version without these changes. +Non-empty service IDs supplied through `HG_SERVER_SERVICE_ID`, `SERVICE_ID`, or `server.serviceId` +must use printable ASCII; spaces and backslashes are supported, while deployment checks reject +non-ASCII and control characters. This entrypoint restriction does not change Core Service naming +or existing manually supplied properties. Helm preserves dollar signs in `server.serviceId` literally, +including `$(POD_IP)`; this field does not expand Kubernetes environment references. +Set the identity through these chart values; Server `extraEnv` reserves both the new and legacy identity variable names. +`HG_SERVER_GRAPHSPACE`, the effective `GRAPH_SPACE` fallback, +and `server.graphSpace` accept `DEFAULT` or an existing space name of up to 48 lowercase letters, digits, +and underscores, starting with a letter: + +```bash +helm upgrade --install hg ./helm/hugegraph \ + --set-string server.serviceId=analytics \ Review Comment: The current head now labels these deployment settings as proposed and unreleased, links the actual paired Server #3322 proposal instead of a master README that lacks the feature, and requires matching PR chart/image builds. It also states the coordinated merge and merged-code recheck requirement. The default hook alias and the need to create the target graph separately from its graph space are explicit; a successful DEFAULT binding check does not establish non-default discovery. The matching Server follow-up is now publicly available on org #297 / ASF #3322, but #3322 remains OPEN, not merged. ASF Doc #517 has been converted to draft and the draft state was read back. I am leaving this thread open until Server #3322 merges and this guidance is rechecked against the merged code, as requested. Full non-default PD discovery, authentication and isolation acceptance also remain open. Both language pages passed the strict Hugo/link/render checks and independent documentation review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
