bitflicker64 commented on code in PR #517: URL: https://github.com/apache/hugegraph-doc/pull/517#discussion_r4275523781
########## content/en/docs/quickstart/hugegraph/hugegraph-server.md: ########## @@ -123,6 +123,59 @@ The standalone `docker-compose.yml` example uses `hugegraph/hugegraph:1.7.0`; it See [docker/README.md](https://github.com/apache/hugegraph/blob/master/docker/README.md) for the full setup guide. +#### Server service identity with PD + +For a PD-backed Server, the Helm chart exposes `server.serviceId` and `server.graphSpace`. +Both default to `DEFAULT`, which preserves the existing `server.service_id` and `server.graphspace` +values in `conf/rest-server.properties`. A non-default chart value injects `HG_SERVER_SERVICE_ID` +or `HG_SERVER_GRAPHSPACE` into the Server container. Use a Helm chart and Server image from the same +version supporting service identity. Review Comment: Important: The open thread on line 148 asked for this section to wait for apache/hugegraph#3322, which is still open. This head did not do that: it removed the #3322 link, and line 132 now asks for a chart and image "from the same version supporting service identity". No published chart or image has that support, so the page now presents these settings as available and gives no way to find a build that has them. Evidence beyond that thread: `server.testGraphAlias` (lines 157 and 170, added since that review) is also #3322-only (`values.yaml` line 341 at 411835f4); on master 4b77b7bcb the hook hard-codes `DEFAULT-hugegraph` (`helm/hugegraph/templates/tests/test-connection.yaml` line 81), and the master chart rejects all three keys: ``` $ helm template hg ./helm/hugegraph --set-string server.serviceId=analytics \ --set-string server.graphSpace=team_a --set-string server.testGraphAlias=team_a-demo - at '/server': additional properties 'graphSpace', 'serviceId', 'testGraphAlias' not allowed ``` Line 163 now ends with "See the Helm chart documentation for details" with no link; the master chart README has no such section. CN lines 131, 150, 156 and 161 match. Requested change: keep this section (EN 126-177, CN 126-166) out of this PR until #3322 merges, then re-check it against the merged chart and link the README section. If it must land first, state that no released chart or image supports these settings yet. ########## content/en/docs/guides/hugegraph-docker-cluster.md: ########## @@ -221,12 +221,28 @@ Unlike PD and Store, Server has no mandatory entrypoint variables: only set valu | `HG_SERVER_PD_REST_ENDPOINT` | Derived from `pd.peers` by replacing `:8686` with `:8620` | PD REST address polled by `wait-storage.sh` | | `PD_AUTH_USER` | `store` | Basic username for PD REST calls from `wait-storage.sh` | | `PD_AUTH_PASSWORD` | Empty | PD REST Basic password; must match `HG_PD_AUTH_SECRET_KEY` when PD REST authentication is enabled | -| `WAIT_PARTITION_TIMEOUT_S` | `120` | Partition allocation wait time in `wait-partition.sh` | +| `WAIT_PARTITION_TIMEOUT_S` | `120` | Partition polling timeout; also bounds the final diagnostic in builds with the fix described below | + +Images containing the authentication property fixes preserve spaces, backslashes and Unicode in explicit Review Comment: Minor: This head replaced the links to merged apache/hugegraph#3327 and #3316 with "images containing the authentication property fixes" (here) and "repaired Server builds" (line 240); line 224 points at line 240, so it lost its boundary too. Line 170 scopes these tables to current master, but an image built from master before #3316 (merge 6aa362a3, 2026-10-12) or #3327 (merge 7a84cde0, 2026-10-13) lacks this behaviour, and the reader can no longer tell which builds have it. The same happened to the #3305 and #3310 links on the Store page (lines 301 and 314) and the PD page (line 322). Requested change: name the boundary, for example "master builds that include apache/hugegraph#3327", or the first release that ships the fix once known. CN docker-cluster lines 226 and 237, Store lines 300 and 313, and PD line 320 need the same change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
