imbajin commented on code in PR #517: URL: https://github.com/apache/hugegraph-doc/pull/517#discussion_r4276294459
########## content/en/docs/guides/hugegraph-docker-cluster.md: ########## @@ -221,12 +221,28 @@ Unlike PD and Store, Server has no mandatory entrypoint variables: only set valu | `HG_SERVER_PD_REST_ENDPOINT` | Derived from `pd.peers` by replacing `:8686` with `:8620` | PD REST address polled by `wait-storage.sh` | | `PD_AUTH_USER` | `store` | Basic username for PD REST calls from `wait-storage.sh` | | `PD_AUTH_PASSWORD` | Empty | PD REST Basic password; must match `HG_PD_AUTH_SECRET_KEY` when PD REST authentication is enabled | -| `WAIT_PARTITION_TIMEOUT_S` | `120` | Partition allocation wait time in `wait-partition.sh` | +| `WAIT_PARTITION_TIMEOUT_S` | `120` | Partition polling timeout; also bounds the final diagnostic in builds with the fix described below | + +Images containing the authentication property fixes preserve spaces, backslashes and Unicode in explicit +signing keys. Use the same key on every Server replica. When upgrading from an image that misread such a key, explicitly supply the intended +`HG_SERVER_AUTH_TOKEN_SECRET` again; retaining the old configuration also retains its misread key. If the active key changes, sign in again to +obtain new tokens. The 1.7.0 image limitation above still applies. + +Older images could initialize a Unicode administrator password incorrectly when the initializer inherited the C locale. Upgrading or setting +`PASSWORD` again does not repair an existing account's stored password. A working administrator must change it through the +[user API](/docs/clients/restful-api/auth/). This fix provides no automatic recovery when no administrator identity is usable; preserve the +existing data and arrange account recovery before upgrading. > **Deprecated aliases**: `BACKEND` → `HG_SERVER_BACKEND`, `PD_PEERS` → > `HG_SERVER_PD_PEERS`. `wait-storage.sh` waits up to 300 seconds for an `Up` Store. This duration is hardcoded and cannot be changed through environment variables. +In repaired Server builds, HStore startup gives partition polling +and the final `/v1/partitions` diagnostic separate `WAIT_PARTITION_TIMEOUT_S` budgets. Earlier builds bound polling only; the final diagnostic +request has no timeout. With the default value, a stalled final response times out after 120 seconds; setting the value to `0` disables +GNU timeout's limit. JVM exit observation may wait until that diagnostic completes or reaches its timeout; signal-triggered shutdown remains Review Comment: ⚠️ Important. Blocking: no. Summary: This mentions only the final diagnostic, but the entrypoint waits for `wait-partition.sh` before waiting for the Java launcher. If Java exits while partition polling is still waiting, that poll can consume its timeout first; if polling succeeds, the diagnostic can then use a second full timeout. Please document both possible delays. Evidence: master `docker-entrypoint.sh:341-347` waits for the partition process before the launcher; `wait-partition.sh:37-49,55-59` applies separate polling and diagnostic timeouts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
