bitflicker64 commented on code in PR #508: URL: https://github.com/apache/hugegraph-doc/pull/508#discussion_r4256494121
########## content/en/docs/quickstart/hugegraph/hugegraph-server.md: ########## @@ -525,10 +554,10 @@ This indicates the successful creation of the sample graph. | Option | Values | Default | Purpose | |---|---|---|---| | `-d` | `true`, `false` | `true` | Daemon mode. With `-d false` the script stays in the foreground and forwards `SIGTERM`/`SIGINT` to the server. | -| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC is accepted, any other value aborts the startup. ZGC needs Java 11 or later. | +| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC is accepted, any other value aborts the startup. | | `-m` | `true`, `false` | `false` | Install the cron-based monitor task (`bin/start-monitor.sh`). For VM and bare-metal deployments only. | | `-p` | `true`, `false` | `false` | Preload the sample graph, as in 5.1.4. | -| `-s` | `true`, `false` | `true` | Run with the security check (`HugeSecurityManager`) enabled. It requires Java 11 to 23 and a readable `conf/java-security.properties`. | +| `-s` | `true`, `false` | `true` | Enable `HugeSecurityManager`; requires readable `conf/java-security.properties`. | Review Comment: Minor: The Java upper bound of the security check was removed here and in section 2.1, but the launcher still enforces it. Evidence, from apache/hugegraph master at 0b7c0de: `bin/hugegraph-server.sh` sets `MIN_JAVA_VERSION=17` and `MAX_SECURITY_JAVA_VERSION=23`, and with `-s true` (the default) on a newer JDK it exits with "The security check requires Java 17-23 ... JDK 24+ removed the Security Manager (JEP 486)". The launcher only rejects versions below 17, so a reader on Java 25 passes the version check and then fails on the default start. `content/en/docs/download/download.md` line 12 and `content/cn/docs/download/download.md` line 11 also send readers to this section "for other supported JDKs", and after this change the section lists none. Please keep the range, for example "requires Java 17 to 23 and a readable `conf/java-security.properties`; on Java 24 or later start with `-s false`", in this row and in section 2.1. The same applies to line 557 and section 2.1 of the CN page. ########## content/en/docs/quickstart/hugegraph/hugegraph-server.md: ########## @@ -525,10 +554,10 @@ This indicates the successful creation of the sample graph. | Option | Values | Default | Purpose | |---|---|---|---| | `-d` | `true`, `false` | `true` | Daemon mode. With `-d false` the script stays in the foreground and forwards `SIGTERM`/`SIGINT` to the server. | -| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC is accepted, any other value aborts the startup. ZGC needs Java 11 or later. | +| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC is accepted, any other value aborts the startup. | Review Comment: Minor: This row is edited here but still does not match the launcher on master, which this page says it follows for startup behaviour. Evidence, from `bin/hugegraph-server.sh` at apache/hugegraph 0b7c0de: the `case "$GC_OPTION"` block accepts `g1` and `G1` (adds `-XX:+UseG1GC`) as well as `zgc` and `ZGC`. With `-g` omitted it prints "Using JVM garbage collector configuration" and adds no collector flag, so G1 is not forced. Only other values abort, with "supported options: g1, ZGC". Please list `g1`/`G1` and `zgc`/`ZGC` as accepted values and describe the default as the JVM's own collector choice. Line 554 of the CN page needs the same change. ########## content/en/docs/quickstart/hugegraph/hugegraph-server.md: ########## @@ -35,17 +35,46 @@ flowchart TD ## 2 Dependency for Building/Running -### 2.1 Install Java 11 (JDK 11) +<span id="21-install-java-11-jdk-11"></span> -The `hugegraph-server` module in HugeGraph 1.7.0 is compiled with Java 11. Running and building it from source require Java 11 or later. +### 2.1 Install Java 17 (JDK 17) -**Before continuing, run `java -version` to confirm your JDK version.** - -> Java 8 is no longer supported starting from 1.7.0. `bin/hugegraph-server.sh` refuses to start on anything older than Java 11. +Starting with HugeGraph 1.8.0, use **Java 17**; **1.7.0 is the last release supporting Java 11**. +Build all modules with **JDK 17 and Maven 3.6.3 or later**, and run Server, PD and Store with **JDK 17**. Review Comment: Minor: This line says PD and Store run with JDK 17 and builds need Maven 3.6.3, but the PD and HStore quick starts in the same section still state the old requirements. Evidence at this head: `content/en/docs/quickstart/hugegraph/hugegraph-pd.md` lines 28-29 and `hugegraph-hstore.md` lines 25-26 say "Java version: >= 11" and "Maven version: >= 3.5.0", and the HStore page adds that `bin/start-hugegraph-store.sh` re-checks it. The CN pages say the same, and CN `hugegraph-pd.md` line 304 says the script needs JDK 11 or later. On apache/hugegraph master at 0b7c0de both `start-hugegraph-pd.sh` and `start-hugegraph-store.sh` set `EXPECT_JDK_VERSION=17`, and the root `pom.xml` enforces Maven `[3.6.3,)`. Please add the same 1.8.0 boundary to those pages in this PR, or link them to this section, so the three quick starts do not disagree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
