imbajin commented on code in PR #508:
URL: https://github.com/apache/hugegraph-doc/pull/508#discussion_r4263650488


##########
content/en/docs/quickstart/hugegraph/hugegraph-server.md:
##########
@@ -525,10 +554,10 @@ This indicates the successful creation of the sample 
graph.
 | Option | Values | Default | Purpose |
 |---|---|---|---|
 | `-d` | `true`, `false` | `true` | Daemon mode. With `-d false` the script 
stays in the foreground and forwards `SIGTERM`/`SIGINT` to the server. |
-| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC 
is accepted, any other value aborts the startup. ZGC needs Java 11 or later. |
+| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC 
is accepted, any other value aborts the startup. |
 | `-m` | `true`, `false` | `false` | Install the cron-based monitor task 
(`bin/start-monitor.sh`). For VM and bare-metal deployments only. |
 | `-p` | `true`, `false` | `false` | Preload the sample graph, as in 5.1.4. |
-| `-s` | `true`, `false` | `true` | Run with the security check 
(`HugeSecurityManager`) enabled. It requires Java 11 to 23 and a readable 
`conf/java-security.properties`. |
+| `-s` | `true`, `false` | `true` | Enable `HugeSecurityManager`; requires 
readable `conf/java-security.properties`. |

Review Comment:
   Restored the Java 17-23 range description for HugeSecurityManager and added 
explicit instructions to run with -s false on JDK 24+ in both section 2.1 and 
startup options tables.



##########
content/en/docs/quickstart/hugegraph/hugegraph-server.md:
##########
@@ -525,10 +554,10 @@ This indicates the successful creation of the sample 
graph.
 | Option | Values | Default | Purpose |
 |---|---|---|---|
 | `-d` | `true`, `false` | `true` | Daemon mode. With `-d false` the script 
stays in the foreground and forwards `SIGTERM`/`SIGINT` to the server. |
-| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC 
is accepted, any other value aborts the startup. ZGC needs Java 11 or later. |
+| `-g` | `zgc` or `ZGC` | omit for G1GC | Garbage collector to use. Only ZGC 
is accepted, any other value aborts the startup. |

Review Comment:
   Updated -g option description to list g1/G1 and zgc/ZGC, noting that 
omitting -g uses the JVM default collector.



##########
content/en/docs/quickstart/hugegraph/hugegraph-server.md:
##########
@@ -35,17 +35,46 @@ flowchart TD
 
 ## 2 Dependency for Building/Running
 
-### 2.1 Install Java 11 (JDK 11)
+<span id="21-install-java-11-jdk-11"></span>
 
-The `hugegraph-server` module in HugeGraph 1.7.0 is compiled with Java 11. 
Running and building it from source require Java 11 or later.
+### 2.1 Install Java 17 (JDK 17)
 
-**Before continuing, run `java -version` to confirm your JDK version.**
-
-> Java 8 is no longer supported starting from 1.7.0. `bin/hugegraph-server.sh` 
refuses to start on anything older than Java 11.
+Starting with HugeGraph 1.8.0, use **Java 17**; **1.7.0 is the last release 
supporting Java 11**.
+Build all modules with **JDK 17 and Maven 3.6.3 or later**, and run Server, PD 
and Store with **JDK 17**.

Review Comment:
   Aligned HugeGraph-PD and HugeGraph-Store prerequisites and startup script 
descriptions with Java 17 and Maven 3.6.3+ for HugeGraph 1.8.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to