bitflicker64 commented on code in PR #508:
URL: https://github.com/apache/hugegraph-doc/pull/508#discussion_r4273003460
##########
content/en/docs/quickstart/hugegraph/hugegraph-hstore.md:
##########
@@ -22,8 +22,8 @@ Each Store node keeps graph data in RocksDB and replicates it
with Raft (JRaft):
#### 2.1 Requirements
- Operating System: Linux or macOS (Windows has not been fully tested)
-- Java version: ≥ 11 (enforced by the build and re-checked by
`bin/start-hugegraph-store.sh`)
-- Maven version: ≥ 3.5.0
+- Java version: ≥ 17 for HugeGraph 1.8.0+ (enforced by the build and
re-checked by `bin/start-hugegraph-store.sh`; 1.7.0 is the last release
supporting Java 11)
Review Comment:
Important: This line says Java `≥ 17` is "enforced by the build", but the
build accepts only JDK 17, so a reader on JDK 21 who follows section 3.2 here
fails before compiling. This line came from the fix for the earlier PD/HStore
thread.
Evidence, apache/hugegraph master at 06f90a9f0: root `pom.xml` sets
`java.supported.version.range` to `[17,18)` ("Java 17 is the only qualified
build/runtime release") and the enforcer applies it. `mvn -N validate` there
fails on JDK 26 with "not in the allowed range [17,18)" and passes on JDK 17.
Only the start scripts accept newer runtimes. EN `hugegraph-pd.md` line 28
(beside its own section 3.2), CN `hugegraph-hstore.md` line 25 and CN
`hugegraph-pd.md` line 28 say the same.
Please split build and run on all four lines, for example "Java 17 for
HugeGraph 1.8.0+ (the Maven build accepts only JDK 17; the start script rejects
anything older; 1.7.0 is the last release supporting Java 11)".
##########
content/en/docs/quickstart/hugegraph/hugegraph-server.md:
##########
@@ -35,17 +35,49 @@ flowchart TD
## 2 Dependency for Building/Running
-### 2.1 Install Java 11 (JDK 11)
+<span id="21-install-java-11-jdk-11"></span>
-The `hugegraph-server` module in HugeGraph 1.7.0 is compiled with Java 11.
Running and building it from source require Java 11 or later.
+### 2.1 Install Java 17 (JDK 17)
-**Before continuing, run `java -version` to confirm your JDK version.**
-
-> Java 8 is no longer supported starting from 1.7.0. `bin/hugegraph-server.sh`
refuses to start on anything older than Java 11.
+Starting with HugeGraph 1.8.0, use **Java 17**; **1.7.0 is the last release
supporting Java 11**.
Review Comment:
Minor: This sets the 1.8.0 boundary, but pages outside this PR still give
Java 11 as the requirement for master and the next release.
Evidence at this head: `content/en/docs/guides/faq.md` line 17 (CN line 17)
tells readers with a startup crash to confirm "Java 11 or later".
`content/en/docs/contribution-guidelines/validate-release.md` lines 8, 26 and
140 (CN lines 8, 24 and 129) tell release verifiers to use Java 11, which fails
the `[17,18)` enforcer on master at 06f90a9f0 and will fail for the 1.8.0 vote.
`hugegraph-server-idea-setup.md` line 19 (CN line 18) asks for Java 11 to build
master in IDEA, where `maven.compiler.release` is now 17.
Please update those pages here or in a linked follow-up, scoping Java 11 to
1.7.0 and earlier.
##########
content/en/docs/quickstart/hugegraph/hugegraph-server.md:
##########
@@ -159,13 +191,13 @@ A successful build logs:
[INFO] BUILD SUCCESS
```
-The build creates an aggregate master archive under repository-root `target/`
(the current source version property is 1.7.0):
+The build creates an aggregate master archive under repository-root `target/`
(the current source version property is 1.8.0):
Review Comment:
Minor: This now says the source version is 1.8.0, but the version-scope note
at line 17 of the same page still says a master build is not an ASF release
"even if its version number matches 1.7.0". With master at
`<revision>1.8.0</revision>` (apache/hugegraph 06f90a9f0), that example no
longer applies.
Please reword line 17 to not tie the master build to 1.7.0, for example
"even if its version number matches a release". CN line 17 ("即使包内版本号相同也不代表与
1.7.0 发布包相同") needs the same change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
