bitflicker64 commented on code in PR #3336: URL: https://github.com/apache/hugegraph/pull/3336#discussion_r4258769930
########## hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh: ########## @@ -104,3 +104,6 @@ $TRAVIS_DIR/build-report.sh $BACKEND $JACOCO_PORT $REPORT_FILE # stop server $TRAVIS_DIR/stop-server.sh $SERVER_DIR + +# Inspect service output after shutdown so background failures cannot pass the suite. +bash "$TRAVIS_DIR/check-java-runtime-logs.sh" "$SERVER_DIR/logs" Review Comment: Important: this gate fails the HBase API suite at this head. In `Server Compatibility CI` run 38376376283, `build-server-backends / server_hbase (Java 17)`, step `Run api test` ran 183 tests with 0 failures and then exited 1 here: ``` Java runtime compatibility error in hugegraph-server/apache-hugegraph-server-1.8.0//logs/hugegraph-server.log: 10:java.lang.reflect.InaccessibleObjectException: Unable to make static boolean java.nio.Bits.unaligned() accessible: module java.base does not "opens java.nio" to unnamed module @7f552bd3 ``` The source is `HBasePlatformDependent.checkUnaligned` in hbase-shaded-client 2.6.5 (reached from `HbaseTables$Counters.<clinit>`), which catches the exception, logs it at WARN and falls back to non-Unsafe reads. It is printed by `init-store.sh` and by the Server, so it lands in `hugegraph-server.log`, `hugegraph-server-stdout.log` and the step output that the workflow checks again. The same job on master `0b7c0de3` (run 38364779759) prints the same line and passes, so the red job comes from this PR. Requested change: add `--add-opens=java.base/java.nio=ALL-UNNAMED` to Server's `jvm-module.options` (the access HBase asks for on Java 17) and rerun the hbase job to see whether the client then asks for further opens. If HBase's fallback is the intended behaviour instead, give the checker an explicit, documented exception for this one message so the hbase job is green without hiding other denied accesses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
