imbajin commented on code in PR #3336:
URL: https://github.com/apache/hugegraph/pull/3336#discussion_r4265844194
##########
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh:
##########
@@ -60,6 +60,12 @@ LOGS="$TOP/logs"
OUTPUT=${LOGS}/hugegraph-pd-stdout.log
GITHUB="https://github.com";
PID_FILE="$BIN/pid"
+JVM_MODULE_OPTIONS="$BIN/jvm-module.options"
+
+if [[ ! -f "$JVM_MODULE_OPTIONS" || ! -r "$JVM_MODULE_OPTIONS" ]]; then
Review Comment:
Fixed: each component's launcher fixture now copies its own shipped
jvm-module.options. Fresh PD-only and Store-only runs, plus both component
orders, pass with the real Java 17 JVM. These checks validate launcher
arguments without starting the applications. Formatting, clean compilation and
the three independent reviews also passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
