bitflicker64 commented on code in PR #532: URL: https://github.com/apache/hugegraph-doc/pull/532#discussion_r4298625256
########## content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md: ########## @@ -140,8 +153,13 @@ Partition patrol repairs shard membership; leader balance is a separate manual t Before either task, identify the PD leader through authenticated `/v1/members` (`data.pdLeader.restUrl`) and confirm its `/v1/ready` reports `isLeader: true`. The GET tasks `/v1/task/patrolPartitions` and `/v1/task/balanceLeaders` change cluster state; target that confirmed leader with PD REST credentials. Wait for membership recovery and split/move tasks to finish before balancing leaders; Stores must have fresh heartbeats and groups full, healthy membership. -A busy task returns body `status: 1001`. A follower may return empty success, and leader transfers are asynchronous: +A busy task returns body `status: 1001`. Older images may return empty success from a follower, and leader transfers are asynchronous: HTTP 200 or a transfer plan does not prove completion. Recheck `/v1/partitions`, `/v1/stores` and application errors before further maintenance. + +With the [task response fix](https://github.com/apache/hugegraph/pull/3359), followers return body `status: 100`, naming the known leader's Raft address. +Partition patrol also reports `reallocatedShardGroups` and `offlineShardRequests`; empty results mean no changes were scheduled. +Offline-shard requests do not prove successful repairs. A skipped partition balance returns `{"status":0,"outcome":"skipped"}`; Review Comment: Minor: this section only asks the reader to call `/v1/task/patrolPartitions` and `/v1/task/balanceLeaders`, so "a skipped partition balance" reads as the leader balance. The skipped body comes only from `/v1/task/balancePartitions` (`TaskAPI.balancePartitions` in apache/hugegraph#3359 at 277bfea0, when `balancePartitionShard` returns `null`). `balanceLeaders` has no skipped outcome: its gates throw `PDException(1001, ...)`, the busy body this page already describes. The literal is also unstable: `Map.of` key order varies per JVM (six fresh JVMs split 2/4), so after a PD restart the body can serialize as `{"outcome":"skipped","status":0}`. Please name `/v1/task/balancePartitions` in the skipped clause, or drop that clause and keep the `{}` part, which is right for `balanceLeaders`. Describe fields rather than the literal, e.g. "`status: 0` with `outcome: skipped`". The Chinese page has the same sentence at line 152, and #3359's api-reference quotes the same literal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
