imbajin commented on code in PR #532: URL: https://github.com/apache/hugegraph-doc/pull/532#discussion_r4310512301
########## content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md: ########## @@ -31,10 +31,18 @@ Store wait and Helm test reuse existing component images with `curl` already ins PD listens on REST 8620, gRPC 8686 and Raft 8610; Store on REST 8520, gRPC 8500 and Raft 8510; Server HTTP on 8080; Hubble HTTP on 8088. Client Services hide individual Pod addresses. NodePort is a separate allocated port on reachable nodes, not the application listener port. -PD `/v1/ready` requires a Raft leader; `/v1/health` only confirms the listener. Store startup waits for a majority of ready PD peers. +PD `/v1/ready` requires a Raft leader. On older images, `/v1/health` only confirms the listener. +Store startup waits for a majority of ready PD peers. Server waits up to `server.storageWaitTimeoutSeconds` (default 300) before its application startup; adjust it for slow storage bootstrap. No local Helm rendering verifies live cluster reachability, volumes or JVM capacity. +Images containing the [fatal PD health fix](https://github.com/apache/hugegraph/pull/3358) return `503` from `/v1/health` +after a terminal Raft error or shutdown; ordinary elections and quorum loss remain live (`200`). +After a failed snapshot, fix the disk or storage problem before restarting PD: freeing space alone does not reinitialize JRaft. Review Comment: ⚠️ Important: Blocking: no. Summary: When `pd.replicas` is greater than 1, the chart defaults startup and liveness probes to `/v1/health`; a fatal-state `503` therefore restarts the PD automatically, but this guidance only explains the single-PD `/v1/ready` behavior. Evidence: `hugegraph.pd.livenessPath` selects `/v1/health` for replicas greater than 1, and `pd-statefulset.yaml` uses that path for both probes; #3358 makes `/v1/health` return `503` for `STATE_ERROR` and `STATE_SHUTDOWN`. Requested change: State the multi-PD default and clarify how the disk-repair guidance relates to those automatic restarts; mirror the explanation in Chinese. ########## content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md: ########## @@ -127,6 +135,17 @@ Use `store.updateStrategy.type=OnDelete` for a controlled maintenance rollout, a Delete one Store Pod at a time. Before replacing the next, verify the previous Pod is Ready, has a fresh Store heartbeat and each shard group has its full membership and exactly one leader, read from the PD leader. PD's `Up` status alone does not prove completed shard recovery. PDBs limit voluntary eviction, not StatefulSet controller disruption. Stop on missing members or leaders. + +Images containing the [Store registration fix](https://github.com/apache/hugegraph/pull/3362) register `Up` after local engine restore +and report `Offline` on graceful shutdown. Upgrade PD before Store to enable the restore gate. Review Comment: ⚠️ Important: Blocking: no. Summary: The shutdown report is best-effort; if PD does not accept the RPC, the Store still shuts down and PD retains its previous record until the existing lease expires. Evidence: #3362 `HeartbeatService.reportOffline()` catches `PDException` and `RuntimeException`, logs that heartbeat expiry is the fallback, and proceeds with shutdown. Requested change: Qualify the Offline signal as conditional on PD accepting the RPC and describe lease expiry on failure; mirror this in Chinese. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
