pallavithegod commented on code in PR #532:
URL: https://github.com/apache/hugegraph-doc/pull/532#discussion_r4306805403


##########
content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md:
##########
@@ -31,10 +31,18 @@ Store wait and Helm test reuse existing component images 
with `curl` already ins
 
 PD listens on REST 8620, gRPC 8686 and Raft 8610; Store on REST 8520, gRPC 
8500 and Raft 8510; Server HTTP on 8080; Hubble HTTP on 8088.
 Client Services hide individual Pod addresses. NodePort is a separate 
allocated port on reachable nodes, not the application listener port.
-PD `/v1/ready` requires a Raft leader; `/v1/health` only confirms the 
listener. Store startup waits for a majority of ready PD peers.
+PD `/v1/ready` requires a Raft leader. On older images, `/v1/health` only 
confirms the listener.
+Store startup waits for a majority of ready PD peers.
 Server waits up to `server.storageWaitTimeoutSeconds` (default 300) before its 
application startup; adjust it for slow storage bootstrap.
 No local Helm rendering verifies live cluster reachability, volumes or JVM 
capacity.
 
+Images containing the [fatal PD health 
fix](https://github.com/apache/hugegraph/pull/3358) return `503` from 
`/v1/health`
+after a terminal Raft error or shutdown; ordinary elections and quorum loss 
remain live (`200`).

Review Comment:
   Rechecked against apache/hugegraph#3358 at e78588131, which preserves 
terminal state across queued callbacks and passes the full PD core profile. The 
paragraph remains conditional on images containing that fix, and the linked 
code/documentation merges need coordination.



##########
content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md:
##########
@@ -127,6 +135,15 @@ Use `store.updateStrategy.type=OnDelete` for a controlled 
maintenance rollout, a
 Delete one Store Pod at a time. Before replacing the next, verify the previous 
Pod is Ready, has a fresh Store heartbeat and each shard group has its
 full membership and exactly one leader, read from the PD leader. PD's `Up` 
status alone does not prove completed shard recovery.
 PDBs limit voluntary eviction, not StatefulSet controller disruption. Stop on 
missing members or leaders.
+
+Images containing the [Store registration 
fix](https://github.com/apache/hugegraph/pull/3362) register `Up` after local 
engine restore
+and report `Offline` on graceful shutdown. Upgrade PD before Store to enable 
the restore gate.
+Temporary Offline reports preserve the existing keepalive window without 
renewing it; expiry still applies if the Store does not return.

Review Comment:
   The current code in apache/hugegraph#3362 renews leases during slow or 
failed restoration through Offline registrations while an owned worker restores 
engines. Both language pages now distinguish that renewal from shutdown expiry.



##########
content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md:
##########
@@ -127,6 +135,15 @@ Use `store.updateStrategy.type=OnDelete` for a controlled 
maintenance rollout, a
 Delete one Store Pod at a time. Before replacing the next, verify the previous 
Pod is Ready, has a fresh Store heartbeat and each shard group has its
 full membership and exactly one leader, read from the PD leader. PD's `Up` 
status alone does not prove completed shard recovery.
 PDBs limit voluntary eviction, not StatefulSet controller disruption. Stop on 
missing members or leaders.
+
+Images containing the [Store registration 
fix](https://github.com/apache/hugegraph/pull/3362) register `Up` after local 
engine restore
+and report `Offline` on graceful shutdown. Upgrade PD before Store to enable 
the restore gate.

Review Comment:
   The current Store revision in apache/hugegraph#3362 uses a dedicated 
ReportStoreShutdown RPC that bypasses the administrative cluster-readiness 
check. Both pages describe the older-PD expiry fallback, and the service-level 
regression covers a non-OK cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to