imbajin commented on code in PR #2945:
URL: https://github.com/apache/hugegraph/pull/2945#discussion_r4297690365
##########
hugegraph-store/Dockerfile:
##########
@@ -35,7 +35,8 @@ RUN
--mount=type=cache,id=hugegraph-maven-${SOURCE_REVISION},target=/root/.m2,sh
# 2nd stage: runtime env
# Note: ZGC (The Z Garbage Collector) is only supported on ARM-Mac with java >
13
-FROM eclipse-temurin:17-jre-jammy
+# Local Arthas attach requires the JDK attach and compiler modules.
Review Comment:
Minor CI regression at this revision: this runtime-stage comment is above
the second FROM, so the existing build-stage extractor includes it in the text
compared with hugegraph-pd/Dockerfile. The current Docker job fails the “Verify
shared Maven stages stay identical” comparison with exit 1. Move this
explanation below the runtime FROM in all three affected Dockerfiles,
preserving the JDK runtime base and the shared-stage check. I independently
replayed the exact extractor: all three comparisons fail now and pass after
relocating only this comment. The same CI job successfully built the images and
passed standalone and PD/Store/Server graph CRUD smoke; this is a textual
CI-contract failure, not an observed runtime build failure. [CI
evidence](https://github.com/apache/hugegraph/actions/runs/38940056673/job/117107152759)
· [Exact-version comparison
logic](https://github.com/apache/hugegraph/blob/6b5c875f14b966387e6e4f0152f17b43fe16ef6f/.github/workflows/docker-build-ci.yml#L57
-L83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
