bitflicker64 commented on code in PR #532: URL: https://github.com/apache/hugegraph-doc/pull/532#discussion_r4322108183
########## content/en/docs/quickstart/hugegraph/hugegraph-helm-operations.md: ########## @@ -127,6 +137,21 @@ Use `store.updateStrategy.type=OnDelete` for a controlled maintenance rollout, a Delete one Store Pod at a time. Before replacing the next, verify the previous Pod is Ready, has a fresh Store heartbeat and each shard group has its full membership and exactly one leader, read from the PD leader. PD's `Up` status alone does not prove completed shard recovery. PDBs limit voluntary eviction, not StatefulSet controller disruption. Stop on missing members or leaders. + +Images containing the [Store registration fix](https://github.com/apache/hugegraph/pull/3362) register `Up` after local engine restore +and attempt to report `Offline` on graceful shutdown; PD changes its record only if it accepts the report. Upgrade PD before Store to enable the restore gate. +Shutdown reports preserve the existing keepalive window without renewing it; expiry still applies if the Store does not return. +During recovery, Offline registrations renew the returned Store's lease while its engines restore on an owned worker. +The shutdown RPC requires a privileged internal credential: set `HG_PD_AUTH_SECRET_KEY` in Store to match PD's `auth.secret-key`. Review Comment: Minor: On this Helm page, "set `HG_PD_AUTH_SECRET_KEY` in Store" reads as a manual step, but the chart in apache/hugegraph#3362 (head ebdc8386) already does it. `store-statefulset.yaml` adds `HG_PD_AUTH_SECRET_KEY` from `secretKeyRef` `hugegraph.pd.authSecretName` / `hugegraph.pd.authSecretKey`, the same Secret and key that `pd-statefulset.yaml` gives PD, and `credential_contract_test.yaml` asserts it for `pd.auth.existingSecret` and `pd.auth.key`. The only way to follow this sentence with the chart is `store.extraEnv`, which renders after the chart's entry, so a mismatched value silently replaces the chart's Secret reference and the shutdown report is refused (Store then falls back to lease expiry). The open review on #3362 also asks for this name to become reserved in `store.extraEnv`, which would make the step fail to render. Please say that the chart passes PD's auth Secret (`pd.auth.existingSecret` / `pd.auth.key`) to Store automatically, and keep the manual `HG_PD_AUTH_SECRET_KEY` instruction only for deployments outside this chart or chart versions without #3362. Make the same change to line 137 of the Chinese page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
