bitflicker64 commented on PR #3399:
URL: https://github.com/apache/hugegraph/pull/3399#issuecomment-6468540490

   ## Review summary (R1, full review)
   
   **Score: 8/10. Not ready to merge yet: one Important issue is still open.**
   
   Reviewed the full diff `a8fac1bc..989d5320` (21 files). Four review lanes 
were requested. Two have finished (Codex, and Copilot running Gemini) and two 
are still pending (Claude, Antigravity). The lead checked the remaining concern 
directly against the head code.
   
   ### Still open
   
   - **Important: startup fails on a DB directory that a snapshot load left 
without `LOCK`** (`LegacyGraphIdChecker.java:298`, existing thread 
r4371956048). `RocksDBSession.loadSnapshot` hard-links checkpoint files into 
`db/<partition>_<v1>`. Those files never include `LOCK`, and `verifySnapshot` 
uses `openReadOnly`, so it doesn't create one either. 
`BusinessHandlerImpl.loadSnapshot` then calls `destroyGraphDB`, and the DB is 
reopened read-write only on the next `getSession` for that partition. If the 
Store stops before that, `checkStore` → `DatabaseLocks.add` calls 
`resolve("LOCK").toRealPath()` and throws `NoSuchFileException`. That becomes a 
`StartupPreflightException` and exit 1, even though the data is healthy. 
Suggested fix: skip the lock when `LOCK` is absent, since no writer can hold it 
then, and add a test that starts against a checkpoint-built DB directory.
   
   ### Fixed at this head
   
   - Docker build context: `.dockerignore` now re-includes 
`docs/graphid-upgrade.md`, and `docker-build` passes.
   - `StoreNodeApplication` now exits with status 1 only when the cause chain 
contains `StartupPreflightException`. Other startup failures (for example, no 
PD) behave as before, and `pd_store / store` passes.
   
   ### Checks and limits
   
   - At this head, CI shows 15 passing and 4 skipped.
   - One lane ran the new GraphID tests (29 tests) plus `GraphIDManagerTest` 
and `BatchGraphIsolationTest` (30 tests) in an isolated build. All passed.
   - Not run: a multi-node upgrade or recovery test.
   - Non-blocking: the paired `apache/hugegraph-doc` PR that `AGENTS.md` asks 
for is still pending, as the PR description notes.
   
   This summary will be updated in place if the pending lanes report anything 
new.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to