bitflicker64 commented on PR #3399:
URL: https://github.com/apache/hugegraph/pull/3399#issuecomment-6476340737

   The earlier review comments below still apply at 827e6c1; this head does not 
fix them.
   
   - Important: `loadSnapshot` moves a checkpoint (no `LOCK` file) into 
`db/<partition>_<v1>`, and only a later read-write open creates `LOCK`, so a 
Store stopped or crashed in between now fails startup here with a bare 
`NoSuchFileException` from `toRealPath()` on healthy data. In 
`DatabaseLocks.add`, skip locking when `LOCK` is absent, since no RocksDB 
writer can hold it, and add a test that starts against a checkpoint-made DB 
directory. 
(https://github.com/apache/hugegraph/pull/3399#discussion_r4371956048)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to