lplalbert opened a new pull request, #418:
URL: https://github.com/apache/hugegraph-ai/pull/418
Refs #107 (Tiny Task: fix TODO/FIXME in LLM code)
## What
The `test_config.py` FIXME asked for tests proving two config contracts:
`.env` sync
preserves typed numeric/boolean fields, and imports do not create or mutate
files
implicitly. This adds that coverage — test-only, no production changes.
## Changes
- `test_env_export_round_trip_preserves_typed_fields`: exports via
`generate_env()`
and reloads a fresh `LLMConfig` — `int`, `bool False`, and `float 0.0`
(the falsy
cases) keep type and value through the quoted-string dotenv serialization.
- `test_config_import_creates_no_config_files` and
`test_config_import_does_not_mutate_existing_config_files`: a
clean-interpreter
import of `hugegraph_llm.config` with explicit `HUGEGRAPH_LLM_*` path
overrides
creates no `.env` / `settings.yaml` / `config_prompt.yaml`, and leaves
pre-existing
ones byte-identical.
## Validation (actually run; offline only)
- `SKIP_EXTERNAL_SERVICES=true uv run pytest src/tests/config/` → 70 passed,
2 failed — the 2 failures are pre-existing on Windows
(`test_external_config.py`
asserts POSIX 0600 file-mode bits) and unrelated to this diff
- `uv run --extra dev ruff format --check .` / `ruff check .` → clean (588
files)
- `uv run --extra dev ty check hugegraph-llm/src/hugegraph_llm` → 271 (same
as
current `main`)
- Real-provider verification: none (offline tests only)
Refs #107
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]