imbajin commented on code in PR #418:
URL: https://github.com/apache/hugegraph-ai/pull/418#discussion_r4522029894


##########
hugegraph-llm/src/tests/config/test_config.py:
##########
@@ -87,3 +86,103 @@ def test_env_path_prefers_explicit_override(self):
         custom_env = Path("/tmp/hugegraph-llm-test.env")
         with patch.dict(environ, {base_config.ENV_PATH_ENV_VAR: 
str(custom_env)}):
             self.assertEqual(Path(base_config.resolve_env_path()), custom_env)
+
+
+_ENV_SCRUB_PREFIXES = (
+    "OPENAI_",
+    "OLLAMA_",
+    "CHAT_",
+    "EXTRACT_",
+    "TEXT2GQL_",
+    "EMBEDDING_",
+    "RERANKER_",
+    "COHERE_",
+    "CO_API_",
+    "HUGEGRAPH_LLM_",
+)
+

Review Comment:
   🧹 The scrub list omits `HYBRID_`, so a valid `HYBRID_LLM_WEIGHTS=0.5` in the 
test environment makes `generate_env()` skip that field and the new export 
assertion fail even when export works correctly. Please clear this variable (or 
all tested field names and aliases) before constructing the settings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to