lplalbert commented on PR #418: URL: https://github.com/apache/hugegraph-ai/pull/418#issuecomment-6755334795
Good catch — pushed (ee193ab). Reloading `extract_use_chat is False` cannot prove the export happened: `LLMConfig._canonical` derives `extract_use_chat=False` from the other extract fields when the variable is absent. The test now asserts the exported `.env` lines themselves (`EXTRACT_USE_CHAT='False'`, `HYBRID_LLM_WEIGHTS='0.0'`, `OLLAMA_CHAT_PORT='12345'`, `OPENAI_CHAT_TOKENS='4096'`) before the reload assertions, so the falsy cases actually exercise the writer. Config suite: 70 passed (2 pre-existing Windows mode-bit failures in `test_external_config.py`, unrelated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
