rdblue commented on a change in pull request #91: Ignore unsupported partition
fields
URL: https://github.com/apache/incubator-iceberg/pull/91#discussion_r254436756
##########
File path:
api/src/test/java/com/netflix/iceberg/transforms/TestTransformSerialization.java
##########
@@ -80,4 +80,25 @@ public void testTransforms() throws Exception {
Assert.assertEquals("Deserialization should produce equal partition spec",
spec, TestHelpers.roundTripSerialize(spec));
}
+
+ @Test
+ public void testTransformsForwardCompatibility() throws Exception {
+
+ Schema schema = new Schema(
+ Types.NestedField.required(1, "i", Types.IntegerType.get()),
+ Types.NestedField.required(2, "d", Types.DateType.get()),
+ Types.NestedField.required(3, "s", Types.StringType.get())
+ );
+
+ PartitionSpec spec = PartitionSpec.builderFor(schema)
+ .identity("i")
+ .year("d")
+ .month("d")
+ .day("d")
+ .add(3, "b", "noSuchTransform?!")
Review comment:
How does the builder succeed with this transform?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
