rdblue commented on a change in pull request #91: Ignore unsupported partition fields URL: https://github.com/apache/incubator-iceberg/pull/91#discussion_r256980409
########## File path: api/src/main/java/com/netflix/iceberg/transforms/UnknownTransform.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package com.netflix.iceberg.transforms; + +import com.netflix.iceberg.expressions.BoundPredicate; +import com.netflix.iceberg.expressions.Expressions; +import com.netflix.iceberg.expressions.UnboundPredicate; +import com.netflix.iceberg.types.Type; + +class UnknownTransform<S, T> implements Transform<S, T> { + + private final Type type; + private final String transform; + + public UnknownTransform(Type type, String transform) { + this.type = type; + this.transform = transform; + } + + @Override + public T apply(S value) { + throw new IllegalArgumentException( + "Unknown transform: " + transform + " for type: " + type.typeId().name()); + } + + @Override + public boolean canTransform(Type type) { + // Assuming the transform function can be applied for this type + return true; Review comment: I think it would be more clear to state that this assumes that the transform is valid because unknown transform is only used when parsing a transform in an existing table. That is, some other Iceberg version has already validated this. There is no way to use the unknown transform specifically. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
