rdblue commented on a change in pull request #91: Ignore unsupported partition fields URL: https://github.com/apache/incubator-iceberg/pull/91#discussion_r256982873
########## File path: api/src/test/java/com/netflix/iceberg/transforms/TestUnknownTransform.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package com.netflix.iceberg.transforms; + +import static com.netflix.iceberg.TestHelpers.assertAndUnwrapUnbound; +import static com.netflix.iceberg.expressions.Expressions.greaterThanOrEqual; +import static com.netflix.iceberg.expressions.Expressions.lessThanOrEqual; +import static com.netflix.iceberg.expressions.Expressions.or; +import static com.netflix.iceberg.types.Types.NestedField.optional; +import static com.netflix.iceberg.types.Types.NestedField.required; + +import com.netflix.iceberg.PartitionSpec; +import com.netflix.iceberg.Schema; +import com.netflix.iceberg.expressions.Expression; +import com.netflix.iceberg.expressions.Expressions; +import com.netflix.iceberg.expressions.Or; +import com.netflix.iceberg.expressions.Projections; +import com.netflix.iceberg.expressions.UnboundPredicate; +import com.netflix.iceberg.types.Types; +import org.junit.Assert; +import org.junit.Test; + +public class TestUnknownTransform { + + @Test + public void testUnknownTransform() { + Schema schema = new Schema( + required(1, "id", Types.LongType.get()), + optional(2, "before", Types.DateType.get()), + required(3, "after", Types.DateType.get())); + + PartitionSpec spec = PartitionSpec.builderFor(schema) + .day("before") + .add(3, "after_unknown_transform", "unknown") Review comment: I don't think that the builder should allow unknown transforms from the public API. This should go through a protected method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
