rdblue commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r266691525
##########
File path: data/src/main/java/com/netflix/iceberg/data/IcebergGenerics.java
##########
@@ -59,13 +60,25 @@ public ScanBuilder where(Expression rowFilter) {
return this;
}
+ public ScanBuilder caseInsensitive() {
Review comment:
`IcebergGenerics` is a builder, not a refinement pattern. It is used to
build and execute a scan. We use this for our Java client, where users read
directly from tables. The builder pattern is better for users. (The refinement
pattern is good for passing partially configured scans to other components.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
