rdblue commented on a change in pull request #89: Make read-path Evaluators
honor case sensitivity flag. Expose flag in Spark Reader.
URL: https://github.com/apache/incubator-iceberg/pull/89#discussion_r267041010
##########
File path: data/src/main/java/com/netflix/iceberg/data/IcebergGenerics.java
##########
@@ -59,13 +60,25 @@ public ScanBuilder where(Expression rowFilter) {
return this;
}
+ public ScanBuilder caseInsensitive() {
Review comment:
Yes, both. I think it is good to have a couple of versions of methods like
these that set booleans. For example, `Tasks` exposes
[`throwFailureWhenFinished()`](https://github.com/apache/incubator-iceberg/blob/master/core/src/main/java/com/netflix/iceberg/util/Tasks.java#L108-L121)
as well as `suppressFailureWhenFinished()` and
`throwFailureWhenFinished(boolean)` that all control a boolean variable. That
allows passing a boolean through using the last case, but also makes it easy to
set the option to a constant.
This is a minor update and not that important, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
