rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r276804577
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -171,7 +168,7 @@ public InclusiveManifestEvaluator load(Integer specId) {
new ScanEvent(table.toString(), snapshot.snapshotId(), rowFilter,
schema()));
Iterable<ManifestFile> matchingManifests =
Iterables.filter(snapshot.manifests(),
- manifest ->
evalCache.getUnchecked(manifest.partitionSpecId()).eval(manifest));
+ manifest ->
evalCache.get(manifest.partitionSpecId()).eval(manifest));
Review comment:
Yeah, if this doesn't pull in transitive dependencies, then it sounds like a
win. Guava's API here isn't reliable anyway, so it's probably better in the
long run. Let's move to caffeine then!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
