rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r280632627
##########
File path: core/src/main/java/org/apache/iceberg/util/Tasks.java
##########
@@ -273,6 +269,16 @@ public boolean run(Task<I, RuntimeException> task) {
return !threw;
}
+ private void tryRunOnFailure(I item, Exception failure) {
+ try {
+ onFailure.run(item, failure);
+ } catch (Exception failException) {
+ failure.addSuppressed(failException);
+ LOG.error("Failed to clean up on failure", failure);
Review comment:
I think you're right. It should log `failException`. At least we're adding
it as a suppressed exception so it is still available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
