rdblue commented on a change in pull request #153: [Baseline] Apply baseline
linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r280631872
##########
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -237,19 +235,19 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst) {
/**
* Deletes the file from the file system. Any RuntimeException will be
caught and returned.
*
- * @param location the file to be deleted.
+ * @param path the file to be deleted.
* @return RuntimeException caught, if any. null otherwise.
*/
- private RuntimeException tryDelete(Path location) {
+ private RuntimeException tryDelete(Path path) {
try {
- io().deleteFile(location.toString());
+ io().deleteFile(path.toString());
return null;
} catch (RuntimeException re) {
return re;
}
}
- protected FileSystem getFS(Path path, Configuration conf) {
- return Util.getFS(path, conf);
+ protected FileSystem getFileSystem(Path path, Configuration hadoopCOnf) {
Review comment:
Nit: typo in COnf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
