aokolnychyi commented on a change in pull request #198: [Baseline] Apply
Baseline to iceberg-data #156
URL: https://github.com/apache/incubator-iceberg/pull/198#discussion_r289604856
##########
File path: data/src/test/java/org/apache/iceberg/data/RandomGenericData.java
##########
@@ -229,7 +231,8 @@ private static Object generatePrimitive(Type.PrimitiveType
primitive, Random ran
case DATE:
// this will include negative values (dates before 1970-01-01)
- return EPOCH_DAY.plusDays(random.nextInt() % ABOUT_380_YEARS_IN_DAYS);
Review comment:
Would it be easier to simply suppress `RandomModInteger`? I think this what
was done in `RandomAvroData` and that's what I did locally in iceberg-spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
