aokolnychyi commented on a change in pull request #198: [Baseline] Apply
Baseline to iceberg-data #156
URL: https://github.com/apache/incubator-iceberg/pull/198#discussion_r289604386
##########
File path: data/src/main/java/org/apache/iceberg/data/avro/DataReader.java
##########
@@ -58,8 +58,8 @@ private DataReader(Schema readSchema) {
}
@Override
- public void setSchema(Schema fileSchema) {
- this.fileSchema = Schema.applyAliases(fileSchema, readSchema);
+ public void setSchema(Schema schema) {
Review comment:
I believe in previous PRs @mccheah frequently used `fileSchema` ->
`newFileSchema` type of renames to avoid hiding fields in builders. Would it
make sense to make it consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
