aokolnychyi commented on a change in pull request #198: [Baseline] Apply
Baseline to iceberg-data #156
URL: https://github.com/apache/incubator-iceberg/pull/198#discussion_r289604595
##########
File path: data/src/main/java/org/apache/iceberg/data/avro/GenericReaders.java
##########
@@ -128,11 +128,13 @@ protected Record reuseOrCreate(Object reuse) {
}
@Override
+ @SuppressWarnings("checkstyle:hiddenField")
Review comment:
I know this rule is a bit controversial but I think it is better to follow
it everywhere or ignore it globally.
In this particular case, it seems appropriate to follow and, maybe, give
another name to the field. It is not really clear the difference between the
field and passed object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
