rdblue commented on issue #272: Refactor AvroIterable and prevent multiple iterators URL: https://github.com/apache/incubator-iceberg/pull/272#issuecomment-509732151 @vrozov, all of the iterators are closeable, so we should be able to close them as they are consumed to free up resources. We do this in `ParallelIterable` for example. The close method in `CloseableIterable` is really intended to be a second catch-all to avoid eventual leaks. Plus, it allows using try-with-resources: ```java try (AvroIterable records = Avro.read(...).build()) { for (R record : records) { ... } } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
