rdblue commented on issue #272: Refactor AvroIterable and prevent multiple iterators URL: https://github.com/apache/incubator-iceberg/pull/272#issuecomment-511480702 > won't be able to choose to close an iterator as Closeable may be easily lost If the caller cares about the case where a partially consumed iterator is left open until the end of the try block, then they can close it and use a while loop instead of the for loop. It is easy to do this, but most people won't care. Your rewrite assumes that it is reasonable to keep records in memory. That's not necessarily the case.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
