rdblue commented on issue #272: Refactor AvroIterable and prevent multiple iterators URL: https://github.com/apache/incubator-iceberg/pull/272#issuecomment-511000511 To be clear, the problem is that this violates common assumptions that people make about iterables. In Iceberg, we make sure that iterables can be used multiple times and, although we don't use this internally, these are part of the guarantees in the public API. I also disagree with the justification for making this change. Preventing resource leaks is not a valid justification because there are better ways to handle it, like closing when an iterator has been consumed. I'm sorry to hear that this sounds like multiple excuses to you, but I think my position has been consistent. This would make iterables have surprising behavior, which is bad, and doesn't have a strong enough justification for that surprising behavior because I don't think it would be more effective than other changes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
