rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r303258426
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -206,10 +207,22 @@ public ReadBuilder rename(String fullName, String
newName) {
return this;
}
+ /**
+ * Field name to field Id map, constructed from the table properties
+ * The current mapping is from name to field id. Aliases of a column
+ * are stored as separate entries in the map with the same value
+ * TODO: Address case insenstivity
+ * TODO: could a schema have duplicate column names?
+ */
+ public ReadBuilder extNameToId(Map<String, Integer> extNameToId) {
Review comment:
What does "ext" stand for? External? I think it would be more clear to name
this "idMapping".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
