rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r329182692
##########
File path: core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java
##########
@@ -195,6 +196,8 @@ public Schema array(Schema array, Supplier<Schema>
element) {
// element was changed, create a new array
if (elementSchema != array.getElementType()) {
+ // TODO: we do not copy field ids here. Probably not required,
+ // but we do at other places in this class.
Review comment:
This assumes that the incoming Avro schema has field IDs. The only reason to
copy in other places is when we are building a replacement schema for some
reason, like if the map didn't have the LogicalMap annotation (some old
manifest files), or if the value schema is a subset because only some of its
fields were projected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
