rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r326876090
##########
File path: data/src/main/java/org/apache/iceberg/data/avro/IcebergDecoder.java
##########
@@ -166,7 +166,7 @@ public D decode(InputStream stream, D reuse) throws
IOException {
* @param writeSchema the schema used to decode buffers
*/
private RawDecoder(org.apache.iceberg.Schema readSchema,
org.apache.avro.Schema writeSchema) {
- this.reader = new ProjectionDatumReader<>(DataReader::create,
readSchema, ImmutableMap.of());
+ this.reader = new ProjectionDatumReader<>(DataReader::create,
readSchema, ImmutableMap.of(), null);
Review comment:
It would be nice to support name mapping in the message decoder as well.
This is fine for now, but could you open an issue to track adding support for
name mapping for Iceberg generic single-message encoding?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
