rdblue commented on a change in pull request #372: Allow read split behavior
overrides
URL: https://github.com/apache/incubator-iceberg/pull/372#discussion_r313517386
##########
File path: api/src/main/java/org/apache/iceberg/TableScan.java
##########
@@ -58,6 +58,15 @@
*/
TableScan asOfTime(long timestampMillis);
+ /**
+ * Create a new {@link TableScan} from this scan's configuration that will
override the {@link Table}'s read splitting
+ * behavior based on the incoming {@link SplitOptions}.
+ *
+ * @param splitOptions a {@link SplitOptions} containing the splitting
options
+ * @return a new scan based on this with the splitting options set
+ */
+ TableScan splitOptions(SplitOptions splitOptions);
Review comment:
This would also make it easier to translate from Spark to Iceberg. You'd
just need to add all of the options to the scan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
