rdblue commented on a change in pull request #372: Allow read split behavior
overrides
URL: https://github.com/apache/incubator-iceberg/pull/372#discussion_r313639861
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -54,22 +56,24 @@
private final TableOperations ops;
private final Table table;
private final Long snapshotId;
+ private final Map<String, String> options;
private final Schema schema;
private final Expression rowFilter;
private final boolean caseSensitive;
private final boolean colStats;
private final Collection<String> selectedColumns;
protected BaseTableScan(TableOperations ops, Table table, Schema schema) {
- this(ops, table, null, schema, Expressions.alwaysTrue(), true, false,
null);
+ this(ops, table, null, null, schema, Expressions.alwaysTrue(), true,
false, null);
}
- protected BaseTableScan(TableOperations ops, Table table, Long snapshotId,
Schema schema,
- Expression rowFilter, boolean caseSensitive, boolean
colStats,
+ protected BaseTableScan(TableOperations ops, Table table, Long snapshotId,
Map<String, String> options,
Review comment:
Why add options in the middle instead of at the end? Seems like you're
changing more lines by displacing the other arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
