rdblue commented on a change in pull request #372: Allow read split behavior
overrides
URL: https://github.com/apache/incubator-iceberg/pull/372#discussion_r313639543
##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -123,31 +128,46 @@ public TableScan asOfTime(long timestampMillis) {
return useSnapshot(lastSnapshotId);
}
+ @Override
+ public TableScan option(String property, String value) {
+ Map<String, String> localOptions = Maps.newHashMap();
Review comment:
As long as this creates a new map each time, I think it makes sense to use
an ImmutableMap:
```java
ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
builder.putAll(options);
builder.put(property, value);
return newRefinedScan(..., builder.build());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
