rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315464699
##########
File path: core/src/main/java/org/apache/iceberg/OverwriteData.java
##########
@@ -56,14 +67,34 @@ public OverwriteFiles addFile(DataFile file) {
}
@Override
- public OverwriteFiles validateAddedFiles() {
- this.validateAddedFiles = true;
+ public OverwriteFiles deleteFile(DataFile file) {
+ Preconditions.checkState(!overwriteByRowFilter,
+ "Either overwriteByRowFilter or deleteFile should be used, not both");
Review comment:
I don't think these are mutually exclusive. I could still create an
idempotent overwrite that deletes files directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
