rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315462678
##########
File path: core/src/main/java/org/apache/iceberg/OverwriteData.java
##########
@@ -88,6 +119,42 @@ public OverwriteFiles validateAddedFiles() {
}
}
+ if (conflictDetectionFilter != null) {
+ PartitionSpec spec = writeSpec();
+ Expression inclusiveExpr =
Projections.inclusive(spec).project(conflictDetectionFilter);
+ Evaluator inclusive = new Evaluator(spec.partitionType(), inclusiveExpr);
+
+ InclusiveMetricsEvaluator metrics = new
InclusiveMetricsEvaluator(base.schema(), conflictDetectionFilter);
+
+ List<DataFile> newFiles = collectNewFiles(base);
+ for (DataFile newFile : newFiles) {
+ ValidationException.check(
+ !inclusive.eval(newFile.partition()) || !metrics.eval(newFile),
+ "A conflicting file was appended that matches filter '%s': %s",
+ conflictDetectionFilter, newFile.path());
+ }
+ }
+
return super.apply(base);
}
+
+ private List<DataFile> collectNewFiles(TableMetadata meta) {
+ List<DataFile> newFiles = new ArrayList<>();
+
+ Long currentSnapshotId = meta.currentSnapshot() == null ? null :
meta.currentSnapshot().snapshotId();
Review comment:
I think that if the current snapshot is null, the loop is skipped and this
returns an empty list. That's not correct, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
