rdblue commented on a change in pull request #351: Extend Iceberg with a way to
overwrite files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315464206
##########
File path: core/src/main/java/org/apache/iceberg/OverwriteData.java
##########
@@ -19,15 +19,23 @@
package org.apache.iceberg;
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Iterables;
+import java.util.ArrayList;
import java.util.List;
import org.apache.iceberg.exceptions.ValidationException;
import org.apache.iceberg.expressions.Evaluator;
import org.apache.iceberg.expressions.Expression;
+import org.apache.iceberg.expressions.InclusiveMetricsEvaluator;
import org.apache.iceberg.expressions.Projections;
import org.apache.iceberg.expressions.StrictMetricsEvaluator;
public class OverwriteData extends MergingSnapshotProducer<OverwriteFiles>
implements OverwriteFiles {
- private boolean validateAddedFiles = false;
+ private boolean overwriteByRowFilter;
+ private boolean validateAddedFilesMatchOverwriteFilter;
+ private boolean deleteFilesByPath;
+ private Long readSnapshotId;
+ private Expression conflictDetectionFilter;
Review comment:
I'd prefer to add explicit defaults for readability. Is there a reason to
remove them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
