rdsr edited a comment on issue #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#issuecomment-530035202 @rdblue I've updated the approach here. I now pass an optional `NameMapping` to `BuildAvroProjection` field ids are now determined from first the `field-id` property and then from `NameMapping` . The logic of how a field is selected in each of the methods (`field()`, `map()`, `array()` etc) is also slightly changed. The general logic now is 1. If the field does not have the field id (either as a property or in NameMapping) it is not selected 1. if it resulting child node is null it is not selected 1. if its resulting child node is different, a new field is created.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
