rdsr edited a comment on issue #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#issuecomment-538440181 @rdblue, I've addressed some of your comments. For map keys, as I have mentioned above I cannot use `keyValue` schema as a complex key could have newly assigned ids. I've moved the 'id' determining methods to AvroSchemaUtil as u suggested. I was also thinking whether it makes sense to initialize nameMapping with expectedSchema, if there's no nameMapping specified, under `ProjectionDatumReader` . This could help us read old Avro data for tables which do not have external mapping specified.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
