rdsr edited a comment on issue #207: Add external schema mappings for files written with name-based schemas #40 URL: https://github.com/apache/incubator-iceberg/pull/207#issuecomment-533837723 Thanks for the review @rdblue . To be clear, I think you are referring to do something similar to my first approach where I was passing a map to `PruneColumns` to build an intermediate file avro schema, to be passed to `BuildAvroProjection`. So specifically, this ``` Set<Integer> projectedIds = TypeUtil.getProjectedIds(expectedSchema); // pass name mapping here build an intermediate avro file schema Schema prunedSchema = AvroSchemaUtil.pruneColumns(newFileSchema, projectedIds, nameMapping); this.readSchema = AvroSchemaUtil.buildAvroProjection(prunedSchema, expectedSchema, renames); ``` But, this will require building an intermediate file **avro** schema. Is that fine?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
