rdblue commented on a change in pull request #207: Add external schema mappings
for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r329182893
##########
File path: core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java
##########
@@ -219,6 +222,7 @@ public Schema map(Schema map, Supplier<Schema> value) {
// element was changed, create a new map
if (valueSchema != map.getValueType()) {
+ // TODO: we do not copy field ids here
Review comment:
This is okay because this class assumes that the incoming schema has IDs. If
you'd like, we can add Preconditions to check that assumption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
