aokolnychyi commented on a change in pull request #631: Add mechanism to expire
old metadata versions
URL: https://github.com/apache/incubator-iceberg/pull/631#discussion_r346787071
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -268,20 +325,24 @@ public Snapshot currentSnapshot() {
return snapshotLog;
}
+ public List<MetadataLogEntry> previousMetadata() {
Review comment:
Just thinking out loud: is this name the most descriptive?
Is it just me who would expect `previousMetadata` in `TableMetadata` to
return another instance of `TableMetadata`? Isn't the current logic more about
previous metadata files rather than metadata in general? This applies to all
places, like `addPreviousMetadata`, `deleteRemovedMetadata`, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
