aokolnychyi commented on a change in pull request #631: Add mechanism to expire 
old metadata versions
URL: https://github.com/apache/incubator-iceberg/pull/631#discussion_r346988006
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
 ##########
 @@ -268,20 +325,24 @@ public Snapshot currentSnapshot() {
     return snapshotLog;
   }
 
+  public List<MetadataLogEntry> previousMetadata() {
 
 Review comment:
   For example, `previousMetadata` doesn't really return a previous metadata 
instance. Instead, it actually returns a list of previous metadata files. So, 
even `previousMetadataFiles` sounds a bit better to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to