aokolnychyi commented on a change in pull request #631: Add mechanism to expire
old metadata versions
URL: https://github.com/apache/incubator-iceberg/pull/631#discussion_r346784553
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -125,6 +126,49 @@ public String toString() {
}
}
+ public static class MetadataLogEntry {
+ private final long timestampMillis;
+ private final String file;
+
+ MetadataLogEntry(long timestampMillis, String file) {
+ this.timestampMillis = timestampMillis;
+ this.file = file;
+ }
+
+ public long timestampMillis() {
+ return timestampMillis;
+ }
+
+ public String file() {
+ return file;
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (this == other) {
+ return true;
+ } else if (!(other instanceof MetadataLogEntry)) {
+ return false;
+ }
+ MetadataLogEntry that = (MetadataLogEntry) other;
+ return timestampMillis == that.timestampMillis &&
+ java.util.Objects.equals(file, that.file);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(timestampMillis, file);
+ }
+
+ @Override
+ public String toString() {
+ return MoreObjects.toStringHelper(this)
+ .add("timestampMillis", timestampMillis)
Review comment:
nit: seems like this file is still formatted with 8 spaces for continued
indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
